r/aws_{ami,ami_copy,ami_from_instance}: Configurable timeouts. #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Oct 5, 2017
There was a problem hiding this comment.
Hi @jmehnle
thanks for the contribution.
This looks reasonable - just two things to sort out before I click the green merge button:
- Maintainers always modify the Changelog as part of the merging process - this is mainly to avoid conflicts as PRs can sometimes go stale and Changelog changes very often.
- Do you mind passing just the bare minimum to all the waiter functions - i.e.
time.Duration, not the wholeResourceDatawith all fields?
i.e. instead of
resourceAwsAmiWaitForAvailable(d, id, client)resourceAwsAmiWaitForAvailable(d.Timeout(schema. TimeoutCreate), id, client)That way you can also remove the ResourceData mocking in the test.
radeksimko
added
enhancement
|
added 2 commits
October 6, 2017 17:19
…imeout directly rather than entire `ResourceData`.
|
Anything I can do to help this along and get it merged? |
radeksimko
removed
the
waiting-response
radeksimko
approved these changes
Oct 28, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform 0.9.0 introduced a 40-minutes "create" timeout to the
aws_ami,aws_ami_copy,aws_ami_from_instanceresources. AWS instances with large disk volumes take a long time to snapshot, often more than 40 minutes.Terraform recently also introduced configurable timeouts, but this must be implemented on a per-resource basis. This diff implements configurable timeouts for the
aws_ami,aws_ami_copy,aws_ami_from_instanceresources.